Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add terra_classic tokens #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add terra_classic tokens #19

wants to merge 1 commit into from

Conversation

lbunproject
Copy link

@HeesungB
Copy link
Collaborator

@lbunproject Could you rebase main branch?

@lbunproject
Copy link
Author

@lbunproject Could you rebase main branch?

I haven't done that before. Do I check out the repo and then create a new branch with the changes - Then rebase that branch into main?

@dimtoneff
Copy link
Contributor

@lbunproject I've already added a starting support for columbus coins (MIR & BASE). Based on that you can try to:

  1. remove that branch
  2. branch off the main branch of this repo
  3. add the rest of your coins

@HeesungB
Copy link
Collaborator

@lbunproject @dimtoneff Hello.
The rebase is requested because validation was added to this repository.

  1. Could you rename cosmos/terra-classic, images/terra-classic to cosmos/columbus, images/columbus?
  2. Could you change imageUrl of token json file to https://raw.githubusercontent.com/chainapsis/keplr-contract-registry/main/images/columbus/cwLUNC.png that is example of cwLUNCtoken.
  3. Could you resize token image to 256x256px?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbunproject @HeesungB @dimtoneff @ZuluSpl0it