-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bitcoin tx sign page #1382
Open
piatoss3612
wants to merge
44
commits into
rowan/KEPLR-846
Choose a base branch
from
rowan/KEPLR-915
base: rowan/KEPLR-846
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
bitcoin tx sign page #1382
+2,954
−715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… single psbt view
adcc32b
to
6de01e1
Compare
delivan
reviewed
Mar 13, 2025
Comment on lines
+149
to
+153
// 따라서 오류를 반환하지 않고 경고를 반환한다. 사실 이렇게까지 해야할까 싶긴 한데... | ||
if (!availableUTXOsSet.has(key)) { | ||
warnings.push( | ||
`Input ${key} is not available. Please check the utxo.` | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
delivan
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. �background
PushBitcoinTransactionMsg
추가2. stores-bitcoin
3. hooks-bitcoin
4. extension/hooks/bitcoin
5. extension/bitcoin/send
6. extension/bitcoin/tx-sign
7. 미구현 목록
8. 논의가 필요한 사항
isBtcWalletProvider
true일 때 외부에서 요청들어온 것을 처리하는 줄 알았는데, 내부적으로 babylon staking 기능을 구현해놓아서 babylon staking 요청이 들어오면 모두 서명하도록 이렇게 구현해 놓았습니다.bip32Derivation
또는tapBip32Derivation
필드를 확인하고 경로를 적용한 주소를 생성하여 매칭해보는 것이 필요할지