fix: handle deps that also appear in replaces blocks in the go.mod #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hectorj2f <[email protected]>
rawlingsj
reviewed
Jan 17, 2024
luhring
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new version of gobump, we drop any replacement and require block of a dependency we want to add as require or replace.
However when we add a dep to the
depsand this dependency appears on a replace block in the go.mod. We need to use the old.path of the dependency to be able to drop the existing replacement and use the proposed dep bump.To give an example, keda-2.9 has a replacement of the crypto dep that we want to bump https://github.com/kedacore/keda/blob/v2.9.1/go.mod#L99 and it also appears on a require block https://github.com/kedacore/keda/blob/v2.9.1/go.mod#L271. If we need to change the go.mod to use the new dep version, we need to drop the replace and require.