Skip to content

style: Make BlockHeaderTrait::txs_commitment [u8; 32]#2854

Open
kpp wants to merge 3 commits intoneeds-auditfrom
kpp/txs_comm_type
Open

style: Make BlockHeaderTrait::txs_commitment [u8; 32]#2854
kpp wants to merge 3 commits intoneeds-auditfrom
kpp/txs_comm_type

Conversation

@kpp
Copy link
Contributor

@kpp kpp commented Sep 18, 2025

To get rid of wild Into::<[u8; 32]>::into().

@kpp kpp requested a review from eyusufatik as a code owner September 18, 2025 04:27
@kpp kpp added the guest-code label Sep 18, 2025
@auto-assign auto-assign bot requested a review from ercecan September 18, 2025 04:27
@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (needs-audit@89d5b84). Learn more about missing BASE report.

Additional details and impacted files
Files with missing lines Coverage Δ
crates/bitcoin-da/src/spec/header.rs 95.8% <100.0%> (ø)
crates/bitcoin-da/src/spec/short_proof.rs 98.4% <100.0%> (ø)
crates/sequencer/src/runner.rs 92.8% <100.0%> (ø)
...sovereign-sdk/adapters/mock-da/src/db_connector.rs 99.4% <100.0%> (ø)
...ates/sovereign-sdk/adapters/mock-da/src/service.rs 92.8% <100.0%> (ø)
...es/sovereign-sdk/adapters/mock-da/src/types/mod.rs 64.1% <100.0%> (ø)
...reign-sdk/rollup-interface/src/state_machine/da.rs 65.9% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

Proving stats report

Comparing patch(2cca182) to base(6ed8929).

Metric Base Patch Change
Total Cycles 5,920,260,096 5,920,260,096 -
User Cycles 4,812,631,396 4,812,631,396 -
Paging Cycles 943,234,084 943,234,084 -
Reserved Cycles 164,394,616 164,394,616 -
State Diff Size (bytes) 104,526 104,526 -

@eyusufatik eyusufatik changed the base branch from nightly to needs-audit January 7, 2026 15:14
@eyusufatik eyusufatik requested a review from a team as a code owner January 7, 2026 15:14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it makes sense to remove hash type and make prev_hash also [u8; 32]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants