perf(batch-prover): replace blocking fs::write with async tokio::fs::write#2964
Open
anim001k wants to merge 5 commits intochainwayxyz:nightlyfrom
Open
perf(batch-prover): replace blocking fs::write with async tokio::fs::write#2964anim001k wants to merge 5 commits intochainwayxyz:nightlyfrom
anim001k wants to merge 5 commits intochainwayxyz:nightlyfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files
🚀 New features to boost your workflow:
|
eyusufatik
previously approved these changes
Oct 14, 2025
jfldde
previously approved these changes
Oct 17, 2025
Author
|
@eyusufatik is it ok to be merged? |
Contributor
|
Please resolve conflicts |
Author
@kpp resolved |
jfldde
reviewed
Oct 30, 2025
jfldde
approved these changes
Oct 30, 2025
rakanalh
approved these changes
Dec 1, 2025
Author
kpp
approved these changes
Dec 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace blocking
std::fs::writewith non-blockingtokio::fs::writein the batch prover RPC module to prevent blocking the Tokio worker thread during file I/O operations.