Skip to content

fix: avoid integer overflow in MB→bytes conversion #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kilavvy wants to merge 2 commits into
base: nightly
Choose a base branch
from
Open

fix: avoid integer overflow in MB→bytes conversion #2974

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46f89b4
Update mempool.rs
kilavvy Oct 14, 2025
cc21f4b
Merge branch 'nightly' into patch-1
kpp Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions crates/sequencer/src/mempool.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,19 @@ impl CitreaMempool {
let evm_config = client.cfg();

// Default 10x'ed from standard limits
const MB_TO_BYTES: u64 = 1024 * 1024;
let pool_config = PoolConfig {
pending_limit: SubPoolLimit {
max_txs: mempool_conf.pending_tx_limit as usize,
max_size: (mempool_conf.pending_tx_size * 1024 * 1024) as usize,
max_size: mempool_conf.pending_tx_size.saturating_mul(MB_TO_BYTES) as usize,
},
basefee_limit: SubPoolLimit {
max_txs: mempool_conf.base_fee_tx_limit as usize,
max_size: (mempool_conf.base_fee_tx_size * 1024 * 1024) as usize,
max_size: mempool_conf.base_fee_tx_size.saturating_mul(MB_TO_BYTES) as usize,
},
queued_limit: SubPoolLimit {
max_txs: mempool_conf.queue_tx_limit as usize,
max_size: (mempool_conf.queue_tx_size * 1024 * 1024) as usize,
max_size: mempool_conf.queue_tx_size.saturating_mul(MB_TO_BYTES) as usize,
},
blob_limit: SubPoolLimit {
max_txs: 0,
Expand Down
Loading