Skip to content

[POC] perf: RecoveredPubkeyProvider#3090

Open
jfldde wants to merge 8 commits intoneeds-auditfrom
perf/zk-ecrecover
Open

[POC] perf: RecoveredPubkeyProvider#3090
jfldde wants to merge 8 commits intoneeds-auditfrom
perf/zk-ecrecover

Conversation

@jfldde
Copy link
Contributor

@jfldde jfldde commented Dec 19, 2025

Description

  • precompute recovered pubkey on native

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 89.09091% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.7%. Comparing base (a9d8009) to head (ac4124d).

Files with missing lines Patch % Lines
crates/recovered-pubkey-provider/src/native.rs 66.6% 6 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
bin/citrea/src/main.rs 80.4% <ø> (ø)
crates/batch-prover/src/prover.rs 97.6% <100.0%> (+<0.1%) ⬆️
crates/citrea-stf/src/verifier.rs 80.3% <ø> (ø)
crates/evm/src/call.rs 97.4% <100.0%> (ø)
crates/evm/src/evm/conversions.rs 96.4% <100.0%> (+1.0%) ⬆️
crates/evm/src/lib.rs 92.9% <ø> (ø)
...rface/src/state_machine/zk/batch_proof/input/v3.rs 88.2% <100.0%> (+0.3%) ⬆️
crates/recovered-pubkey-provider/src/native.rs 66.6% <66.6%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jfldde jfldde marked this pull request as ready for review December 19, 2025 20:32
@jfldde jfldde requested a review from a team as a code owner December 19, 2025 20:32
@auto-assign auto-assign bot requested a review from rakanalh December 19, 2025 20:32
kpp
kpp previously approved these changes Dec 20, 2025
Copy link
Contributor

@kpp kpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@jfldde jfldde changed the title [POC] perf: EcrecoverAddressProvider [POC] perf: RecoveredPubkeyProvider Dec 22, 2025
@chainwayxyz chainwayxyz deleted a comment from github-actions bot Dec 22, 2025
@github-actions
Copy link

github-actions bot commented Dec 22, 2025

Proving stats report

Comparing patch(ac4124d) to base(a9d8009).

Metric Base Patch Change
📉 Total Cycles 5,917,376,512 5,119,148,032 -13.49%
📉 User Cycles 4,811,847,454 4,087,653,116 -15.05%
📉 Paging Cycles 941,130,285 888,985,410 -5.54%
📉 Reserved Cycles 164,398,773 142,509,506 -13.31%
State Diff Size (bytes) 104,526 104,526 -

@jfldde jfldde changed the base branch from nightly to needs-audit January 9, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants