Open
Conversation
ercecan
reviewed
Feb 23, 2026
| rs_merkle = "1.4.2" | ||
| reqwest = { version = "0.12.12", features = ["rustls-tls", "json", "http2"], default-features = false } | ||
| rocksdb = { version = "0.22.0", features = ["lz4"], default-features = false } | ||
| serde = { version = "=1.0.218", default-features = false, features = ["alloc", "derive"] } |
Member
There was a problem hiding this comment.
oh that's a sight for sore eyes
Proving stats reportComparing patch(
|
eyusufatik
pushed a commit
that referenced
this pull request
Feb 25, 2026
# Description - Rest of aws related crates can be removed after #3161 and bumping `boundless-market` to `1.3.3`
ercecan
requested changes
Feb 27, 2026
| network: Network, | ||
| ) -> Result<Dependencies<Self>> { | ||
| let task_manager = TaskManager::current(); | ||
| let task_manager = TaskExecutor::with_existing_handle(tokio::runtime::Handle::current())?; |
Member
There was a problem hiding this comment.
I think rename to task executor
Member
There was a problem hiding this comment.
for all instances that are now executor but named manager
| _= &mut task_manager => {} | ||
| let mut task_manager_handle = task_manager.take_task_manager_handle(); | ||
|
|
||
| if let Some(handle) = &mut task_manager_handle { |
Member
There was a problem hiding this comment.
Is it possible for the handle to be None?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description