Add Munder Difflin benchmark dashboard - #504
Open
saikiran6775 wants to merge 3 commits into
Open
Conversation
- Implement standalone Vite+React dashboard - Load data from HIVE_ROOT via Vite middleware plugin - Add Recharts for Cost/Latency/Model visualizations - Build metrics panels per Architect's plan
- Enforce strict filename mapping for allowed endpoints. - Canonicalize paths using fs.realpathSync to prevent directory escape. - Suppress sensitive file paths in error responses. Signed-off-by: engineer-mtul38ix
Contributor
🚫 This PR is missing its before/after evidenceEvery pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.
How to fix it: edit the description, keep the A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine. Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a standalone in-repo benchmark dashboard for Munder Difflin — a Vite + React + TypeScript SPA under
benchmark-dashboard/that reads the hive run artifacts (log.jsonl,cost-ledger.jsonl,tasks.json,registry.json,fleet.json) fromHIVE_ROOTand visualizes them. The Electron app is untouched (no changes tosrc/main,src/preload, or the renderer).What's included
tasks.json(labeled as such, not an accuracy score; readsresults.jsonlif present).cost-ledger.jsonl, plus an avg/median coordination-latency proxy (message→session ts deltas), clearly labeled as a proxy (not model TTFT).app-startevents./api/*for the hive files;HIVE_ROOToverride in the top bar.package.jsonscripts:dashboard:dev,dashboard:build.benchmark-dashboard/README.md.Security
The data middleware was reviewed and hardened against path traversal (commit
c4f6872b): endpoint→filename is a fixed whitelist, paths are canonicalized withfs.realpathSyncand containment-checked against the resolvedHIVE_ROOT, and error bodies are generic (no path disclosure).Validation
npm run dashboard:build(tsc + vite) passes clean.HIVE_ROOToverride works; empty/error states handled; run segmentation correct; traversal/absolute-path/symlink-escape/bogus-endpoint attempts all blocked with generic errors.Run
Defaults
HIVE_ROOTto the local hive path; overridable in the top bar.🤖 Generated with Claude Code