Skip to content

Fix god command honoring explicit provider - #551

Open
garedrag wants to merge 1 commit into
chaitanyagiri:mainfrom
garedrag:fix/claude-god-provider-command
Open

garedrag wants to merge 1 commit into
chaitanyagiri:mainfrom
garedrag:fix/claude-god-provider-command

Conversation

@garedrag

Copy link
Copy Markdown

Summary\n\n- Ensure an explicit agent provider selects its matching CLI binary when building spawn commands.\n- Prevent a Claude god configured alongside a global Codex default from launching as Codex with Claude-only flags.\n- Preserve custom commands and configured Claude commands that are actually Claude binaries.\n- Add a regression test for defaultCommand=codex with provider=claude.\n\n## Verification\n\n-

ode --test test/provider-config.test.cjs (9 passing)\n- git diff --check (passing)

@github-actions

Copy link
Copy Markdown
Contributor

🚫 This PR is missing its before/after evidence

Every pull request here has to show its work. Screenshots or a short screen recording, before the change and after it.

  • Before — no image or video under that heading
  • After — no image or video under that heading

How to fix it: edit the description, keep the ### Before and ### After headings from the template, and drag an image or video under each. GitHub uploads it inline. This check re-runs the moment you save.

A bug fix with no visible surface still needs it: show the failing behaviour, then the same steps passing. A terminal recording is fine.

Genuinely nothing to show — a CI tweak, a typo, a dependency bump? A maintainer can apply the no-visual-change label. Please don't ask unless it truly has no observable effect.

📖 CONTRIBUTING.md → Evidence is mandatory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant