Optional chaining

[ShortDevelopment]

This PR aims to add support for the stage-4 proposal optional-chaining.
It's inspired by the work of @rhuanjl but uses a more hacky approach to parsing.

Goals

• Minimize amount of changes
• (Hopefully) Performance

ToDo

• Add tests
  • Unused expression result
  • Return expression
  • Root optional-call (e.g. eval?.('a'))
  • Scoped method load (e.g. inside eval)
• implement optional-deletion
• optional call invoked on eval function should be indirect eval
• Simple function calls
• Preserve this
(a.b)().c should be equivalent to a.b().c
• What about the apply call optimization?
• short circuit embedded expressions like a?.[++x]
++x should not be evaluated if a is null or undefined
• Don't tokenize a?.3:0 (ternary) as tkOptChain (?.)
• Tagged templates are not allowed in optional chain
• fix tmp-renaming for eval result
  eval("foo?.()") or eval("foo?.property")

Out of scope

• Remove EmitInvoke (seems unused)
• Better error message for a call on a non-function

---

Spec: Optional Chains
Fixes #6349

[rhuanjl]

I think this looks neater than my version was, though struggling to follow how it handles every branch. What happens if you do a function call in an optional chain does it crash?

(Not going to merge until we have some significant test coverage)

[ShortDevelopment]

I'm currently working on function calls.
At the moment it would just be handled as if no optional-chaining would be used
⇾ crash in js land

Edit: Function call should work now but this is not always propagated correctly (yet)
Edit: Function calls should now work

[ShortDevelopment]

The jitted code currently crashes at this assertion (causing the test-failures)

ChakraCore/lib/Backend/GlobOpt.cpp

Line 11384 in 1f6e17c

Assert(block->globOptData.IsTypeSpecialized(varSym));

[ShortDevelopment]

We "copy" the value from the knopOptChain node to the knopDelete node

[ShortDevelopment]

Instead of acquiring a tmp I copy the location of pnodeOptChain to innerNode
(In case the caller has already aquired a tmp)

ChakraCore/lib/Runtime/ByteCode/ByteCodeEmitter.cpp

Line 63 in 05790ae

innerNode->location = pnodeOptChain->location;

And copy it back after emitting innerNode
(In case the location was NoRegister and the emission of innerNode aquired a tmp)

ChakraCore/lib/Runtime/ByteCode/ByteCodeEmitter.cpp

Line 69 in 05790ae

pnodeOptChain->location = innerNode->location;

[ShortDevelopment]

JavascriptOperators::Delete does only return true. Why can't we just emit bytecode to load true?
Is this because of getter/setter side-effects?

ChakraCore/lib/Runtime/Language/JavascriptOperators.cpp

Lines 534 to 539 in 05790ae

	Var JavascriptOperators::Delete(Var var, ScriptContext* scriptContext)
	{
	JIT_HELPER_NOT_REENTRANT_NOLOCK_HEADER(Op_Delete);
	return scriptContext->GetLibrary()->GetTrue();
	JIT_HELPER_END(Op_Delete);
	}

[rhuanjl]

Sorry for the delay, I was confused when I first looked at this; it appears this OpCode is used only in this one location in the bytecodeemitter and is for a no_op delete, as far as I can see we could indeed replace it with LdTrue and delete the logic for OpCode:Delete_A and the relevant code paths.