-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changeset tag to custom publishing section of README #271
base: main
Are you sure you want to change the base?
Conversation
|
This PR definitely would have saved me reading through the source code |
why is this not being merged? |
Is changesets still maintained? |
@@ -155,6 +157,9 @@ jobs: | |||
- name: Create Release Pull Request or Publish to npm | |||
id: changesets | |||
uses: changesets/action@v1 | |||
with: | |||
# Include this to create GitHub releases and Git tags | |||
# publish: yarn changeset tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbf - I think I have successfully used Changesets with custom release scripts like this:
- name: Create Release Pull Request or Publish to npm
id: changesets
uses: changesets/action@v1
with:
publish: yarn run release
where the release
script be defined like this:
"release": "node ./scripts/release.js && yarn changeset tag"
This way you don't have to rely on steps.changesets.outputs.hasChangeset
at all
@hirasso it's maintained and I plan to spend more time on it in 2025 but it's an unpaid OSS work and my free time has limits 🤷♂️ |
@Andarist sorry if my comment sounded too pushy! I'm an OSS maintainer myself so I should have known better 😇 ...and amazing to hear that changesets is still maintained! I'll leave my working solution here, I was only able to stitch together all required settings after reading through a few issues, PRs and the source code.
with:
publish: pnpm changeset tag
I think with a little more documentation setups like these would become much more straight forward. Thank you for changesets, I love it ❤️ |
Why is this pull request needed?
Based on #269.
What does this pull request change?
Add simple example of custom publishing workflow that produces GitHub Releases and Git tags.