Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix tags not triggering github create event #316

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mckelveygreg
Copy link

We've been loving changesets!

However, I think I finally tracked down an issue we were having.
Our monorepo has a cloudbuild trigger listening to tags, but github doesn't create a Create event when more than 3 tags are created at once... which is unfortunate when we have changes in 5 of our apps...

I did a local test to confirm that as long as tags are pushed one at a time, they all trigger github events.

Let me know if anything should be adjusted or if I didn't account for something!

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2023

🦋 Changeset detected

Latest commit: 55e26c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/action Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tedraykov
Copy link

We are experiencing the same problem when we have a GitHub workflow triggered on a pushed tag. The workflow is not triggered when the changesets action pushes more than 3 tags.

@mckelveygreg
Copy link
Author

@tedraykov To unblock our CI, we released a private fork with this fix in, and reference that in our action instead:

 - name: Create Release Pull Request
        uses: <org>/changesets-action@<tag>

We built it locally, so there was a dist/index.js, and then used that artifact as the release.

@jbltx
Copy link

jbltx commented Nov 16, 2023

Also encountering the same issue. Any mono-repo will eventually face the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants