Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error if our input is missing optional fields. #56

Merged
merged 1 commit into from
Jun 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions platformics/codegen/templates/api/types/class_name.py.j2
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ async def create_{{ cls.snake_name }}(
raise PlatformicsError("Unauthorized: {{cls.name}} is not creatable")
{%- else %}
{%- for field in cls.system_only_create_fields %}
del(params["{{field.name}}"])
params.pop("{{field.name}}", None)
{%- endfor %}
{%- endif %}
{%- endif %}
Expand Down Expand Up @@ -596,7 +596,7 @@ async def update_{{ cls.snake_name }}(
raise PlatformicsError("Unauthorized: {{cls.name}} is not mutable")
{%- else %}
{%- for field in cls.system_only_mutable_fields %}
del params["{{field.name}}"]
params.pop("{{field.name}}", None)
{%- endfor %}
{%- endif %}
{%- endif %}
Expand Down
Loading