Fix unsupported xattrs when running gen_release on mac#26903
Closed
jabraham17 wants to merge 1 commit intochapel-lang:mainfrom
Closed
Fix unsupported xattrs when running gen_release on mac#26903jabraham17 wants to merge 1 commit intochapel-lang:mainfrom
jabraham17 wants to merge 1 commit intochapel-lang:mainfrom
Conversation
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
5 tasks
Member
Author
|
#26913 incorporates the fixes from this PR and improves things more, closing |
jabraham17
added a commit
that referenced
this pull request
Apr 3, 2025
Rewrites `gen_release`, a perl script, with Python. This PR makes two behavior changes to the script - fixes #26794, using the technique described in #26903 - uses `--depth 1` when cloning when `CHPL_GEN_RELEASE_COMMIT` is not set for faster clone times This PR makes minimal changes to the flow of logic in the script (mostly just transliterated perl code), but future work could make use of Python features to improve the script. For example, using https://docs.python.org/3/library/tarfile.html instead of spawning sub-processes to rely on the system `tar`. Note to reviewer: I recommend reviewing this by having the the python code and perl code open side-by-side, as the github diff is confusing Tested that all of the following work - [x] `CHPL_GEN_RELEASE_SKIP_DOCS=1 CHPL_GEN_RELEASE_NO_CLONE=1 ./util/buildRelease/gen_release` - [x] `CHPL_GEN_RELEASE_SKIP_DOCS=1 CHPL_GEN_RELEASE_NO_CLONE=1 ./util/buildRelease/gen_release 2.4.0` - [x] check that the output can be built - [x] `./util/buildRelease/gen_release 2.4.0` - [x] check that the output can be built [Reviewed by @DanilaFe]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26794, which was caused by MacOS tar inserting extra headers unto the tar file. This is done in two ways
--no-xattrsis always used to prevent the vast majority of extra headersgtar(gnu tar) overtarwhen available prevents a handful of extra headersResolves #26794