Skip to content

Install CMake files for Chapel projects#26937

Merged
jabraham17 merged 9 commits intochapel-lang:mainfrom
jabraham17:install-cmake-files
Apr 15, 2025
Merged

Install CMake files for Chapel projects#26937
jabraham17 merged 9 commits intochapel-lang:mainfrom
jabraham17:install-cmake-files

Conversation

@jabraham17
Copy link
Copy Markdown
Member

@jabraham17 jabraham17 commented Mar 18, 2025

Adds an install step to move the CMake module files in util/cmake to CHPL_HOME/lib/INSTALL_PREFIX/lib/cmake/chpl

This makes these files readily available to users without needing to copy the files into their project

testing

  • build from source with CHPL_HOME build puts the files in the right place
  • install from source with chpl-home build puts the files in the right place
  • install from source with prefix build puts the files in the right place
  • homebrew changes work as expected
  • rpm changes work as expected
    • tested fedora 41
  • apt/deb changes work as expected
    • tested ubuntu 24

[Reviewed by @arezaii]

Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
@jabraham17 jabraham17 force-pushed the install-cmake-files branch from 445043a to 3f2bd2c Compare April 14, 2025 15:02
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
@jabraham17 jabraham17 requested a review from arezaii April 14, 2025 21:24
Copy link
Copy Markdown
Contributor

@arezaii arezaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jabraham17 jabraham17 merged commit f19f194 into chapel-lang:main Apr 15, 2025
10 checks passed
@jabraham17 jabraham17 deleted the install-cmake-files branch April 15, 2025 00:04
arifthpe added a commit to arifthpe/homebrew-core that referenced this pull request Sep 19, 2025
arifthpe added a commit to arifthpe/homebrew-core that referenced this pull request Sep 19, 2025
arifthpe added a commit to arifthpe/homebrew-core that referenced this pull request Sep 26, 2025
Apply the following improvements/fixes from upstream releases 2.5 and
2.6:
- chapel-lang/chapel#26937
- chapel-lang/chapel#27535
- chapel-lang/chapel#27546
- chapel-lang/chapel#27564
- chapel-lang/chapel#27626
- chapel-lang/chapel#27653

Additionally, disable gasnet+smp build and test on linux/arm64 to work
around an as yet undiagnosed build failure on the platform.

Includes a hack to allow gasnet+smp checkChplInstall testing to succeed
on a system with less than 4 cores, to be removed once there's an
upstream fix.

Adds a requirement of arm64 arch on macOS, as we've encountered
portability issues with gasnet+smp on x86_64 macOS 14, which we don't
have the time to fix at the moment and aren't worth denying the feature
to other platforms over.
arifthpe added a commit to arifthpe/homebrew-core that referenced this pull request Sep 26, 2025
jabraham17 added a commit to jabraham17/homebrew-core that referenced this pull request Oct 7, 2025
Apply the following improvements/fixes from upstream releases 2.5 and
2.6:
- chapel-lang/chapel#26937
- chapel-lang/chapel#27535
- chapel-lang/chapel#27546
- chapel-lang/chapel#27564
- chapel-lang/chapel#27626
- chapel-lang/chapel#27653
- chapel-lang/chapel#27865

Addresses feedback given in Homebrew#244962

Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants