feat(SearchBar): add enter-key search, read-only mode, focus/blur events, and maxLength support#2
Open
syed-ghufran-hassan wants to merge 1 commit intocharlesbarleyman:mainfrom
Conversation
…nts, and maxLength support Added Enter key support: Pressing Enter triggers onSearch immediately for faster user interaction. Introduced read-only mode via readOnly prop: Input is non-editable. Clear button is hidden when in read-only mode. Added optional maxLength prop to limit input characters. Added focus and blur callbacks (onFocus and onBlur) for better control over input lifecycle events. Ensured backwards compatibility: All existing props (placeholder, debounceMs, showIcon, showClear, etc.) continue to work. Component styling remains unchanged. Maintains memoization and ref forwarding for optimized rendering.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Enter key support: Pressing Enter triggers onSearch immediately for faster user interaction.
Introduced read-only mode via readOnly prop:
Input is non-editable.
Clear button is hidden when in read-only mode.
Added optional maxLength prop to limit input characters.
Added focus and blur callbacks (onFocus and onBlur) for better control over input lifecycle events.
Ensured backwards compatibility:
All existing props (placeholder, debounceMs, showIcon, showClear, etc.) continue to work.
Component styling remains unchanged.
Maintains memoization and ref forwarding for optimized rendering.