add support for nested results property #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 63
💛 - Coveralls |
saiqulhaq
reviewed
Oct 30, 2018
| @@ -301,8 +302,21 @@ export default { | |||
| * @return {Array} | |||
| */ | |||
| setResults (response) { | |||
| if (this.resultsProperty && response[this.resultsProperty]) { | |||
| return response[this.resultsProperty] | |||
| if (this.resultsProperty) { | |||
There was a problem hiding this comment.
if there are only two conditions, it's better to use if else, easier to read
adhithiya05
force-pushed
the
nested-results-property
branch
from
f67e4e5
to
17254b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to access nested data property in response.