Skip to content

Reimagine ceph-csi charm with the reconciler pattern #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Jun 18, 2024

Addresses LP#2068524

Overview

The patterns employed in this charm were difficult to reason about, and in some cases changes occur with no notifications to the charm via config changes or relation changes. Because of this, it's better to employ this charm with a reconciler pattern which can check the necessary state of the charm before configuring/changing the cluster

Details

  • Adds the charm-lib-reconciler library
  • Convert the merge_config method to act as the reconciler function
  • Careful to not use any 1.30 branch reconciler feature so this could be backported to the 1.29 branch if necessary
  • Greatly reduce unit testing
  • Integration testing only changed to support a different "active" status message

@addyess addyess force-pushed the reconciler branch 3 times, most recently from 622506b to ae5c297 Compare June 18, 2024 18:57
@addyess addyess force-pushed the reconciler branch 2 times, most recently from 2ae3984 to 215b9df Compare July 1, 2024 13:13
@addyess addyess force-pushed the reconciler branch 2 times, most recently from cd36d0e to df8da03 Compare September 4, 2024 17:40
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks a lot @addyess! LGTM.

@HomayoonAlimohammadi HomayoonAlimohammadi merged commit 57972cc into main Dec 9, 2024
7 checks passed
@HomayoonAlimohammadi HomayoonAlimohammadi deleted the reconciler branch December 9, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants