Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charm grows the ability to adjust storage class parameters #20

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Jul 16, 2024

Overview

Addresses LP#2073297 by allowing the ceph-csi charm to provision storage-class parameters of each of the Storage Classes created by this charm.

Details

Creates three new config options:

  • cephfs-storage-class-parameters
  • ceph-xfs-storage-class-parameters
  • ceph-ext4-storage-class-parameters

Each of these config options allows one to adjust the parameters of the storage class patched in by the charm.

Storage-Class parameters like these are not run-time updatable yet, but this can be set at charm deploy-time to correctly match any settings on any storage classes which exist in the cluster.

For example)

You may deploy the charm like this:

juju deploy ceph-csi --channel=1.30/stable \
    --config ceph-xfs-storage-class-parameters='removed-key- custom-value=true'

@addyess addyess force-pushed the bug/lp2073297/rbd-sc-parameters branch from e721ee7 to e3373c4 Compare July 16, 2024 21:04
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyess addyess merged commit 32c575f into main Jul 16, 2024
7 checks passed
@addyess addyess deleted the bug/lp2073297/rbd-sc-parameters branch July 16, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants