Adjust the UX of the storage class parameters feature #21
Conversation
addyess
force-pushed
the
bug/lp2073297/rbd-sc-parameters
branch
2 times, most recently
from
ac31374 to
fa415cb
Compare
addyess
force-pushed
the
bug/lp2073297/rbd-sc-parameters
branch
from
fa415cb to
7922bb3
Compare
| name: | ||
| type: string | ||
| description: Name of a specific storage class to delete. | ||
| enum: | ||
| - cephfs | ||
| - ceph-xfs | ||
| - cephfs-ext4 |
There was a problem hiding this comment.
i love that juju supports json-schema for action properties!!
There was a problem hiding this comment.
look how cool:
⚡ juju run ceph-csi/leader delete-storage-class name=thing
Operation 1 failed to schedule any tasks:
validation failed: (root).name : must match one of the enum values ["cephfs","ceph-xfs","cephfs-ext4"], given "thing"
| "pool": f"{self.fs_type}-pool", | ||
| "thickProvision": "false", |
There was a problem hiding this comment.
this has been deprecated since v3.6.0. It has no business being there.
There was a problem hiding this comment.
this may result in situations where the charm fails with an error about not being able to patch the storage class. So we've added this handy action to delete the storage class:
juju run ceph-csi/leader delete-storage-class name=ceph-xfs
juju run ceph-csi/leader sync-resourcesThere was a problem hiding this comment.
if it can't delete the storage class, we're in a real situation here where either the config needs to change to match the installed storage class or the cluster admin needs to check if there are PVCs using that storage class which are incorrectly provisioned
| @@ -80,9 +80,7 @@ def __call__(self) -> Optional[AnyResource]: | |||
| "csi.storage.k8s.io/node-stage-secret-namespace": ns, | |||
| "csi.storage.k8s.io/provisioner-secret-name": StorageSecret.SECRET_NAME, | |||
| "csi.storage.k8s.io/provisioner-secret-namespace": ns, | |||
| "imageFeatures": "layering", | |||
There was a problem hiding this comment.
don't worry, this is moved to the config.yaml
Update
Overview
Addresses LP#2073297 by allowing the ceph-csi charm to provision storage-class parameters of each of the Storage Classes created by this charm.
Details
Creates a delete-storage-class action
Updates three new config options:
cephfs-storage-class-parametersceph-xfs-storage-class-parametersceph-ext4-storage-class-parametersEach of these config options allows one to adjust the parameters of the storage class patched in by the charm.
Storage-Class parameters like these are not run-time updatable yet, but this can be set at charm deploy-time to correctly match any settings on any storage classes which exist in the cluster.
For example)
You may deploy the charm like this:
juju deploy ceph-csi --channel=1.30/stable \ --config ceph-xfs-storage-class-parameters='removed-key- custom-value=true'This ensures that the best defaults possible are baked into the charm config
The charm managed parameters are removable and can be updated (while not recommended), but not listed in the charm config since the charm config doesn't support formatting the configured parameters.