Skip to content

Address missing node-selector charm config #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

addyess
Copy link
Member

@addyess addyess commented Aug 15, 2024

Overview

Addresses LP#2066980
Allows the charm to apply a set of node-selectors to the controller and speaker pods in the cluster

Details

  • Patches both DaemonSet and Deployment of metallb with values for the node-selector
  • Updated CI a bit to run on juju 3/stable and microk8s 1.31-strict/stable
  • Charm builds and runs on jammy using charmcraft 2.x/stable
  • Adds integration tests which confirm the node-selectors are applied

@addyess addyess force-pushed the bug/lp2066980/configure-node-selector branch from edfd10b to 882db96 Compare August 15, 2024 16:41
Copy link
Member

@mateoflorido mateoflorido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice, LGTM

@addyess addyess merged commit ddac181 into main Aug 15, 2024
7 checks passed
@addyess addyess deleted the bug/lp2066980/configure-node-selector branch August 15, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants