Possibility to add more options to the SSH and SCP commands #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library to create Juju charms used in my OSM's VNFs, I felt the need to use other options for the SSH connection. For instance, I couldn't do so, if I had to use the SSH client option
ServerAliveInterval
, because there is not an argument on therun
orssh
functions of theSSHProxy
class to pass these SSH client options.Therefore, the modifications I introduced now allow a developer to add these options that might be useful/needed in some specific cases. For example, if I now have the following code:
The corresponding
ssh
function will produce the command, with this set of wanted options:Note: I also added this possibility to the
scp
function.