Merge pull request #23 from charmed-osm/use-confined-snap

Use strictly confined snap
charmed-osm · May 10, 2023 · 27666c9 · 27666c9
2 parents 8b65855 + b661b86
commit 27666c9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/charm.py b/src/charm.py
@@ -148,7 +148,10 @@ def _on_remove_default_gw_action(self, event: ActionEvent) -> None:
     @staticmethod
     def _install_srsran() -> None:
         """Installs srsRAN snap."""
-        shell("snap install srsran --edge --devmode")
+        shell("snap install srsran --edge")
+        shell("snap connect srsran:network-control")
+        shell("snap connect srsran:process-control")
+        shell("snap connect srsran:system-observe")
         logger.info("Installed srsRAN snap")
 
     @staticmethod

diff --git a/tests/unit/test_charm.py b/tests/unit/test_charm.py
@@ -47,7 +47,14 @@ def test_given_unit_is_leader_when_on_install_then_srsran_snap_is_installed(self
 
         self.harness.charm.on.install.emit()
 
-        patch_shell.assert_called_with("snap install srsran --edge --devmode")
+        patch_shell.assert_has_calls(
+            [
+                call("snap install srsran --edge"),
+                call("snap connect srsran:network-control"),
+                call("snap connect srsran:process-control"),
+                call("snap connect srsran:system-observe"),
+            ]
+        )
 
     @patch("charm.shell", new=Mock())
     def test_given_unit_is_leader_when_install_then_status_is_maintenance(self):