Skip to content

adds limit param to set number of results #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dvdokkum wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adds limit param to set number of results #1

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f34c4c
adds limit param to set number of results
Nov 1, 2013
d51baf6
adds better truthy check for limit param
Nov 4, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/scripts/controllers/cbBigBoardCtrl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,10 @@ angular.module('cbBigBoardCtlr').controller('cbBigBoardCtrl', ['$scope',
if ($scope.hideLandingPages && landingPagesCount[host]) {
limits[host] += landingPagesCount[host];
}
//Force limit from param
if (!isNaN(configService.limit)) {
Copy link

@dbow dbow Nov 3, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you trying to check if 'limit' is defined on the configService object? This seems to specifically just check that configService.limit is not the value NaN. You'd probably want to do just a generic truthy check, since i imagine the limit should never be set to 0 legitimately? Could also just check that typeof limit is 'number'.

limits[host] = configService.limit;
Copy link

@bhstahl bhstahl Dec 6, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try this out? I dont think all params are added to the configService. Alternatively you could do

if ($routeParams.limit) {
limits[host] = $routeParams.limit;
}

Copy link

@bhstahl bhstahl Dec 6, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, alternatively you could extend DEFAULT_LIMIT to $routeParams.limit

}
});
firstSort = true;

Expand Down