fix: Dynamically set max_tokens for SiliconFlow API #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…limit issue Description Updating max_tokens behavior for SiliconFlow API Additional Notes I updated the logic to dynamically set max_tokens based on the model being used. This resolves the issue where the default max_tokens was too short (only 512 tokens as per the official documentation). The new implementation ensures that max_tokens is adjusted according to the specific model's capabilities, aligning with the official guidelines. Contributor Agreement By submitting this Pull Request, I confirm that I have read and agree to the following terms: I agree to contribute all code submitted in this PR to the open-source community edition licensed under GPLv3 and the proprietary official edition without compensation. I grant the official edition development team the rights to freely use, modify, and distribute this code, including for commercial purposes. I confirm that this code is my original work, or I have obtained the appropriate authorization from the copyright holder to submit this code under these terms. I understand that the submitted code will be publicly released under the GPLv3 license, and may also be used in the proprietary official edition. Please check the box below to confirm: [x] I have read and agree with the above statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating max_tokens behavior for SiliconFlow API
Additional Notes
I updated the logic to dynamically set max_tokens based on the model being used. This resolves the issue where the default max_tokens was too short (only 512 tokens as per the official documentation). The new implementation ensures that max_tokens is adjusted according to the specific model's capabilities, aligning with the official guidelines.
Relevant documentation:
Contributor Agreement
By submitting this Pull Request, I confirm that I have read and agree to the following terms:
Please check the box below to confirm:
[x] I have read and agree with the above statement.