This repository was archived by the owner on Feb 23, 2022. It is now read-only.
(CEM-2514) MenuItemCard Component #383
Open
mfnisbetLU wants to merge 15 commits intocheapreats:masterfrom
Open
(CEM-2514) MenuItemCard Component #383mfnisbetLU wants to merge 15 commits intocheapreats:masterfrom
mfnisbetLU wants to merge 15 commits intocheapreats:masterfrom
Conversation
mfnisbetLU
changed the title
Member
Author
|
|
ralph-dev
reviewed
Oct 28, 2021
Member
ralph-dev
left a comment
ralph-dev
left a comment
There was a problem hiding this comment.
Try wrapping the sold out and loyalty points in a div then absolutely positioning that div to have the two pieces aligned.
You can use css justify content space in between to selerate
Revised draft of the menu item card. Changes to formatting, added colors from themes, added a function, changed variable names to match with subcomponents.
ralph-dev
suggested changes
Nov 9, 2021
| *.bundle.* | ||
| storybook-static/* No newline at end of file | ||
| src/Containers/HorizontalScrollList/HorizontalScrollList.tsx | ||
| src/Containers/MiddleCanvas/DroppableElement.tsx |
Comment on lines
+58
to
+67
| { soldOut && <SoldOutBox>Sold Out</SoldOutBox>} | ||
|
|
||
| { !!minsRemaining && | ||
| <LimitedTimeBannerPosition> <LimitedTimeBanner minsRemaining={minsRemaining}/></LimitedTimeBannerPosition> } | ||
|
|
||
| { !!loyaltyamount && | ||
| <LoyaltyPointsPosition> <LoyaltyPoints loyaltyamount={loyaltyamount} loyaltypointlimit = {loyaltypointlimit} /></LoyaltyPointsPosition> } | ||
|
|
||
| { !!saleAmount && | ||
| <SaleTagPosition><SaleTag saleAmount={saleAmount}/></SaleTagPosition> } |
Member
There was a problem hiding this comment.
Can you abstract this all out into a getMenuItemStatus function.
What happens if someone passes in two conflicting states. We will need to override.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is a draft) Initial commit for the menu item card, including composite components CEM-2515/2516/2517.