This repository was archived by the owner on Feb 23, 2022. It is now read-only.
Conversation
ralph-dev
reviewed
Nov 13, 2021
| import {PersonFill} from '@styled-icons/bootstrap/PersonFill' | ||
|
|
||
| export interface IPartySizeSelector { | ||
| person?: React.ForwardRefExoticComponent<React.RefAttributes<SVGSVGElement>>; |
ralph-dev
suggested changes
Nov 13, 2021
Member
ralph-dev
left a comment
ralph-dev
left a comment
There was a problem hiding this comment.
needs to be updated with in meeting feedback
ralph-dev
suggested changes
Nov 17, 2021
Member
ralph-dev
left a comment
ralph-dev
left a comment
There was a problem hiding this comment.
Missing documentation, need to use theme for colors, architecture might be a bit off
ralph-dev
approved these changes
Nov 24, 2021
Member
ralph-dev
left a comment
ralph-dev
left a comment
There was a problem hiding this comment.
LGTM, docs for props missing
Member
|
You've committed to the wrong branch @pavldavid |
Contributor
Author
|
Yes I just saw that I am trying to uncommit right now
…On Mon, Nov 29, 2021, 20:17 Ralph Maamari ***@***.***> wrote:
You've committed to the wrong branch @pavldavid
<https://github.com/pavldavid>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#396 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASPAKHWTQZUSANZUUX2QJRLUORF4LANCNFSM5HXPSBDQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you click anything on the right, everything on the left should be orange.