This repository was archived by the owner on Feb 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
Lakehead - CEM-2602 Profile list with counter #423
Open
percypie
wants to merge
5
commits into
master
Choose a base branch
from
CEM-2602
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9148b9a
Functions but does not adjust position dynamically
percypie cb8190c
Implemented the counter on the existing component
percypie 15feb92
Added a boolean that can be turned on to display counter
percypie 26ae7e1
meeting fixes
percypie 6f34cb1
Changed counterBool to isCounterShowing
percypie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
98 changes: 98 additions & 0 deletions
98
src/Containers/FeaturedProfilesCount/FeaturedProfilesCount.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| import React from 'react'; | ||
| import { Meta, Story } from '@storybook/react'; | ||
| import { createStoryTitle } from '../../Constants'; | ||
| import { FeaturedProfilesCard, IFeaturedProfilesCardProps, FeaturedProfilesCount} from "index"; | ||
|
|
||
| const profiles = [ | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/220453/pexels-photo-220453.jpeg?cs=srgb&dl=pexels-pixabay-220453.jpg&fm=jpg', | ||
| initials: 'AC', | ||
| id: 2345, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/415829/pexels-photo-415829.jpeg?cs=srgb&dl=pexels-pixabay-415829.jpg&fm=jpg', | ||
| initials: 'BD', | ||
| id: 6312, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'CG', | ||
| id: 5455, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'TY', | ||
| id: 5765, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'ER', | ||
| id: 5098, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'GC', | ||
| id: 6355, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'YN', | ||
| id: 7643, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'OY', | ||
| id: 3984, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'MN', | ||
| id: 1734, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'CG', | ||
| id: 9034, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'CG', | ||
| id: 9034, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'CG', | ||
| id: 9034, | ||
| }, | ||
| { | ||
| image: | ||
| 'https://images.pexels.com/photos/3763188/pexels-photo-3763188.jpeg?cs=srgb&dl=pexels-andrea-piacquadio-3763188.jpg&fm=jpg', | ||
| initials: 'CG', | ||
| id: 9034, | ||
| }, | ||
| ]; | ||
|
|
||
| export default { | ||
| title: createStoryTitle('FeaturedProfilesCount'), | ||
| component: FeaturedProfilesCount, | ||
| subcomponent: FeaturedProfilesCard, | ||
| args:{ | ||
| profileData: profiles, | ||
| } | ||
| }as Meta; | ||
|
|
||
| export const Basic: Story<IFeaturedProfilesCardProps> = (args) => ( | ||
| <><FeaturedProfilesCard {...args}/><FeaturedProfilesCount {...args}/></> | ||
| ) |
21 changes: 21 additions & 0 deletions
21
src/Containers/FeaturedProfilesCount/FeaturedProfilesCount.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| import React from 'react'; | ||
| import styled from 'styled-components'; | ||
| import {IFeaturedProfilesCardProps} from 'index'; | ||
|
|
||
| export const FeaturedProfilesCount: React.FC<IFeaturedProfilesCardProps> = ({ | ||
| profileData, //the array of profiles to be displayed. | ||
| ...props | ||
| }): React.ReactElement => ( | ||
| <CountContainer>{profileData.length}</CountContainer> | ||
| ) | ||
|
|
||
| const CountContainer = styled.span` | ||
| position: relative; | ||
| top: -105px; | ||
| left: 660px; | ||
| color: black; | ||
| font-size: 50px | ||
|
|
||
| `; | ||
|
|
||
| //todo Make location change with amount of profiles (currently having issues trying to make Featured profile card not generate a new line without being able to edit it) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?