Fix 3 bad source code merges. #1210
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix some incorrect merges that were causing test failures: - In 2 cases, statements were accidentally deleted. Restore them. - In SemaDecl.cpp, we kept some old code that should have been deleted. This caused processing of section pragmas and section information on declarations to be skipped on non-C++ files. These were identified by looking at diffs with the original clang source code or debugging the handling failing test cases in the compiler. This fixes about 20 failing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some incorrect merges that were causing test failures:
These were identified by looking at diffs with the original clang source code or debugging the handling failing test cases in the compiler.
This fixes 20 failing tests. With this change, the test results from check-clang are: