feat: add support for RetryStrategy #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clample
requested review from
maxigimenez,
pilimartinez,
Antoine-C and
shiini2
as code owners
8 tasks
Antoine-C
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
I'm approving it to unblock you but can't answer for the pointers thing. Maybe @danielpaulus can check this?
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Style
go fmtNotes for the Reviewer
This PR adds support for retry strategies to checks and check groups.
*RetryStrategyrather than aRetryStrategy. This makes it possible to havenilas the retry strategy. I haven't written much Go, so let me know if there's a more idiomatic way to do this. We already do the same forBasicAuthinRequest.