fix: remove permadiff on ssl_check_domain
#286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x416e746f6e
requested review from
maxigimenez,
pilimartinez,
Antoine-C and
shiini2
as code owners
|
Hello @0x416e746f6e 👋 Thanks for the PR, I will take a look at it / merge it next week 🤞 |
hi @Antoine-C! how is it going? |
|
obviously nobody cares |
|
@0x416e746f6e I'm very sorry for dropping the ball here. We will have a look ASAP. |
8 tasks
|
@0x416e746f6e I'm sorry for the very late merge of your fix, it's released in version 1.8.1 of the provider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Pre-Requisites
terraform fmtgo fmtplan&applycommand ofdemo/main.tffile do not produce diffsNotes for the Reviewer