Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add secret variables support [sc-21027] #300

Conversation

maxigimenez
Copy link
Member

Affected Components

  • Resources
  • Test
  • Docs
  • Tooling
  • Other

Pre-Requisites

  • Terraform code is formatted with terraform fmt
  • Go code is formatted with go fmt
  • plan & apply command of demo/main.tf file do not produce diffs

Notes for the Reviewer

Adding new seecret boolean to environment variables, groups & checks

Important

Important note: this feature is not available yet, if you have any questions feel free to reach out to our customer support

@maxigimenez maxigimenez marked this pull request as ready for review September 2, 2024 08:31
Copy link
Contributor

@Antoine-C Antoine-C left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test case for the new secret key? Thanks!

@maxigimenez
Copy link
Member Author

Can you add a test case for the new secret key? Thanks!

@Antoine-C I've added a very simple to test to cover the secret creation

@maxigimenez maxigimenez merged commit 4e8abd7 into main Sep 3, 2024
6 checks passed
@maxigimenez maxigimenez deleted the maxigimenez/sc-21027/add-new-secret-property-to-tf-code-exporter branch September 3, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants