fix: ast builder qa feedbacks #746

ChibiBlasphem · 2025-03-19T15:20:52Z

Fix remanent error in trigger and rules ast builders (need backend PR: fix: fix errors management for ast validation marble-backend#921)
Fix formating of value in IsMultipleOf edit modal
Fix aggregation modal unary operator
Fix unary view mode
Fix viewing operator
Increase font weight of OperatorSelect items

Pascal-Delange

👍 thanks for the quick fix !

ChibiBlasphem requested a review from a team March 19, 2025 15:20

ChibiBlasphem mentioned this pull request Mar 19, 2025

fix: fix errors management for ast validation checkmarble/marble-backend#921

Merged

ChibiBlasphem force-pushed the fix/ast-builder-qa-feedbacks branch 3 times, most recently from 0b4308e to dc07aaf Compare March 19, 2025 17:09

Pascal-Delange approved these changes Mar 19, 2025

View reviewed changes

carere approved these changes Mar 20, 2025

View reviewed changes

carere force-pushed the fix/ast-builder-qa-feedbacks branch from dc07aaf to 4b3e210 Compare March 21, 2025 10:49

ChibiBlasphem added 5 commits March 24, 2025 10:10

fix: root level error remaining

3a218fa

fix: ismultipleof divider formating

614c331

fix: aggregation unary operator required error

f86cc8d

fix: unary operation in view mode

ee9ba86

increase font weight of operator select items

46550d9

ChibiBlasphem force-pushed the fix/ast-builder-qa-feedbacks branch from 4b3e210 to 46550d9 Compare March 24, 2025 09:11

ChibiBlasphem merged commit 3adf09e into main Mar 24, 2025
3 checks passed

ChibiBlasphem deleted the fix/ast-builder-qa-feedbacks branch March 24, 2025 09:13

Provide feedback