Skip to content

Commit 5ef773b

Browse files
authored
Jamie/4701 karma coverage migration (#4843)
* Add karma-coverage package Also removed karma-coverage-istanbul-reporter which this is replacing and made modifications to the karma.conf.js files as noted in karma-coverage docs and https://github.com/angular/angular-cli/blob/v11.0.0/packages/schematics/angular/application/files/karma.conf.js.template Signed-off-by: seajamied <[email protected]> * Remove commented out code Signed-off-by: seajamied <[email protected]> * Change to version in package lock Signed-off-by: seajamied <[email protected]>
1 parent 92e4183 commit 5ef773b

File tree

3 files changed

+47
-57
lines changed

3 files changed

+47
-57
lines changed

components/automate-ui/karma.conf.js

+11-5
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ module.exports = function (config) {
88
plugins: [
99
require('karma-jasmine'),
1010
require('karma-chrome-launcher'),
11+
require('karma-jasmine-html-reporter'),
1112
require('karma-firefox-launcher'),
1213
require('karma-safari-launcher'),
13-
require('karma-jasmine-html-reporter'),
14-
require('karma-coverage-istanbul-reporter'),
14+
require('karma-coverage'),
1515
require('@angular-devkit/build-angular/plugins/karma')
1616
],
1717
files: [
@@ -25,9 +25,15 @@ module.exports = function (config) {
2525
client:{
2626
clearContext: false // leave Jasmine Spec Runner output visible in browser
2727
},
28-
coverageIstanbulReporter: {
29-
dir: require('path').join(__dirname, 'coverage'), reports: [ 'html', 'lcovonly', 'json-summary' ],
30-
fixWebpackSourcePaths: true
28+
29+
coverageReporter: {
30+
dir: require('path').join(__dirname, 'coverage'),
31+
subdir: '.',
32+
reporters: [
33+
{ type: 'html' },
34+
{ type: 'lcovonly' },
35+
{ type: 'json-summary' }
36+
],
3137
},
3238

3339
reporters: ['dots', 'kjhtml'],

components/automate-ui/package-lock.json

+35-51
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

components/automate-ui/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
"karma": "~6.2.0",
9090
"karma-chrome-launcher": "~3.1.0",
9191
"karma-cli": "^2.0.0",
92-
"karma-coverage-istanbul-reporter": "~3.0.2",
92+
"karma-coverage": "^2.0.3",
9393
"karma-firefox-launcher": "^2.1.0",
9494
"karma-jasmine": "~4.0.0",
9595
"karma-jasmine-html-reporter": "^1.5.0",

0 commit comments

Comments
 (0)