teams-service: cut down "create team" error strings #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srenatus
added
bug 🐛
There' some decent guidance here: https://github.com/golang/go/wiki/Errors Error strings should - start with lowercase - be specific: if create fails, don't say that create failed - not end with a period ...because they might be wrapped, as it happens in this case: When this error bubbles up in the UI, it'll say > Could not create team: unable to create team: a team with name "..." already exists.. Signed-off-by: Stephan Renatus <[email protected]>
srenatus
force-pushed
the
sr/nitpicks
branch
2 times, most recently
from
e81c799 to
1610f73
Compare
I've never seen this happen, so we shouldn't sweat it; but
status.Error(codes.Xyz, fmt.Sprintf(..., ...))
should really be
status.Errorf(codes.Xyz, ..., ...)
Signed-off-by: Stephan Renatus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There' some decent guidance here: https://github.com/golang/go/wiki/Errors
Error strings should
...because they might be wrapped, as it happens in this case: When this error
bubbles up in the UI, it'll say