Fixing restore error as migration is skipped #8823
Draft
+68
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rensy Thomas <[email protected]>
✅ Deploy Preview for chef-automate ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
| @@ -332,6 +343,7 @@ func handleBackupCommands(cmd *cobra.Command, args []string, commandString strin | |||
| os.Exit(1) | |||
| } | |||
| if strings.Contains(cmd.CommandPath(), "restore") { | |||
| deleteSkipMigrationFileIfExists(infra) | |||
There was a problem hiding this comment.
please handle error here and formatting
| defer func() { | ||
| if subCommand == "restore" && isSkipMigrationFileExist { | ||
| writer.Body("Creating .skip_migration file") | ||
| createSkipMigrationFile() |
There was a problem hiding this comment.
handle error for this function
| @@ -42,11 +42,22 @@ either all services are up (chef-automate restart-services) | |||
| or all services are down (chef-automate stop) before retrying the restore.` | |||
|
|
|||
| var allPassedFlags string = "" | |||
| var isSkipMigrationFileExist bool = false | |||
There was a problem hiding this comment.
please remove global variables. make them part of struct or function scope
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔩 Description: What code changed, and why?
Fixing restore issue as migration is skipped.
⛓️ Related Resources
👍 Definition of Done
👟 How to Build and Test the Change
✅ Checklist
All PRs must tick these:
With occasional exceptions, all PRs from Progress employees must tick these:
make spellin any component directory)All PRs from Progress employees should tick these if appropriate:
Please add a note next to any checkbox above if you are NOT ticking it.
📷 Screenshots, if applicable