updating new chef client in tests #295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RaviDuddela <[email protected]>
|
Hello raviduddela! Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
1 similar comment
|
Hello raviduddela! Thanks for the pull request! Here is what will happen next:
Thank you for contributing! |
Stromweld
requested changes
Feb 11, 2023
| @@ -9,7 +9,7 @@ pkg_version="1.0.0" | |||
| pkg_scaffolding="ci/scaffolding-chef-infra" | |||
| pkg_svc_user=("root") | |||
| scaffold_policy_name="ci" | |||
| scaffold_chef_client="chef/chef-client/14.13.11" | |||
| scaffold_chef_client="chef/chef-infra-client" | |||
There was a problem hiding this comment.
tests require a version as they parse this line and take the version after the 2nd / character to verify the installed version is the same. https://github.com/chef/effortless/blob/main/scaffolding-chef-infra/tests/user-linux-api/tests/test.bats#L1
Signed-off-by: RaviDuddela <[email protected]>
Signed-off-by: RaviDuddela <[email protected]>
Signed-off-by: RaviDuddela <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RaviDuddela [email protected]