Skip to content

Modified exception handler - handle missing shasum #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
poorndm wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Modified exception handler - handle missing shasum #1176

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f564c6e
Modified exception handler
poorndm Sep 15, 2025
d4f5546
Syntax correction
poorndm Sep 15, 2025
8892bf6
Syntax correction
poorndm Sep 15, 2025
b08b19a
modify the verify_cksum
poorndm Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/omnibus/fetchers/net_fetcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,9 @@
# @return [Symbol]
#
def digest_type
if source[:url].to_s.downcase.end_with?(".git")
return nil
end
DIGESTS.each do |digest|
return digest if source.key? digest
end
Expand All @@ -284,10 +287,18 @@
# if the checksum does not match
#
def verify_checksum!
return if digest_type.nil? # skip verification for git urls

log.info(log_key) { "Verifying checksum" }

# Check if the source is a Git repository
if source[:url] =~ %r{git@|https?:\/\/.*\.git}

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
Loading
that depends on a
library input
Loading
may run slow on strings starting with 'http://' and with many repetitions of 'http://'.
This
regular expression
Loading
that depends on a
library input
Loading
may run slow on strings starting with 'http://' and with many repetitions of 'http://'.
log.warn(log_key) { "Skipping checksum verification for Git source: #{source[:url]}" }
return
end

expected = checksum
actual = digest(downloaded_file, digest_type)
actual = digest(downloaded_file, digest_type)

if expected != actual
raise ChecksumMismatch.new(self, expected, actual)
Expand Down