Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make polyfill configurable #26

Closed
wants to merge 1 commit into from

Conversation

9SMTM6
Copy link

@9SMTM6 9SMTM6 commented Sep 3, 2024

This removes one request whenever a thread is started.

It makes sense if your application already requires even more modern APIs, in my case webgpu.

Note that for this to be observable, I did need to cargo clean before the build. I'm not entirely sure why that was required.

@chemicstry
Copy link
Owner

Thanks for the PR!

I don't think adding additional features is necessary so I fixed it by inlining js in #29. Let me know if this works for your usecase.

@chemicstry chemicstry closed this Oct 14, 2024
@9SMTM6
Copy link
Author

9SMTM6 commented Oct 14, 2024

I mean, it still means that there is additional data to be transferred on initial request, however it does get rid of the network request, and doesn't require a feature. I understand why you want to avoid that, and this brings me 80% of the way, so its fine.

Thanks for addressing this!

@9SMTM6
Copy link
Author

9SMTM6 commented Oct 14, 2024

I'd appreciate it if you could do a 3.1 release or something at some point in the somewhat close future (month or similar).

Also, btw, the links in the readme are not quite up to date. Concretely the ones I saw are in the limitations section the webworker.js and the hack.

@9SMTM6
Copy link
Author

9SMTM6 commented Oct 15, 2024

@chemicstry IDK if you get pinged without this, sorry if you did get pinged already, this isn't meant to put on any pressure.

@chemicstry
Copy link
Owner

Fixed the links, thanks for pointing out, and released a new version. Sorry for taking so long.

@9SMTM6
Copy link
Author

9SMTM6 commented Oct 20, 2024

No issue at all. Thanks for doing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants