fix(opencode): stream persistent HTTP sessions#1535
Open
zmlgit wants to merge 6 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
connection_urlmode that talks toopencode serveover HTTP and keeps/eventSSE connected before prompts are sent./session/{id}/messagerequest is still running, preserving progress updates and background callbacks.Why
opencode run --attachis short-lived in cc-connect. When the client process exits at the end of a turn, OpenCode server-side background callbacks can be lost. The OpenCode CLI already subscribes to/eventSSE internally; this patch mirrors that behavior in cc-connect whenconnection_urlis configured.Related: #1534, especially #1534 (comment)
Test Plan
GOCACHE=/tmp/cc-connect-go-cache go test ./agent/opencode -count=1GOPATH=/tmp/cc-connect-go GOMODCACHE=/tmp/cc-connect-go/pkg/mod GOCACHE=/tmp/cc-connect-go-cache go build ./...opencode serve:OPENCODE_LIVE_URL=... OPENCODE_LIVE_USERNAME=... OPENCODE_LIVE_PASSWORD=... OPENCODE_LIVE_SEND=1 go test ./agent/opencode -run TestOpencodeHTTPModeLiveServer -count=1 -v