Add Raysect 0.8 compatibility#379
Conversation
Only changes needed to build the project without errors are included.
|
I think it would be good to push out a Cherab release against 0.7.1 first, and then incorporate the changes required for 0.8 into a subsequent release. It's possible that the API breakage in 0.7.1 may break some users' downstream workflows if they use raysect features directly as well as Cherab. |
|
Yes, that's probably right. I'll leave this PR open for the future though. |
|
Now that Cherab 1.4.0 is out I think we can look at updating the development branch for raysect 0.8. Tests all pass: any objections to the merge? |
|
not from my side, thanks |
|
Just one thing, can we temporarily specify that we need |
|
Not too keen on working around raysect's bugs, but in this case setting a limit on the matplotlib version does seem like a pragmatic solution. I'll make the change. |
|
I'll release Raysect v0.8.1 this weekend, if I get time. |
|
Thanks @CnlPepper. In that case I propose we wait until 0.8.1 is out and then just support that going forwards. I can't see anything in the 0.8.1 changelog that would affect Cherab: there are no instances of |
|
@jacklovell I've released Raysect 0v.8.1. It fixes a number of niggling issues, such as the deprecated matplotlib window title call. If there are any further issues, let me know. |
|
@jacklovell, should we add the |
|
I'd recommend you do. Anaconda and other python distributions seem to have changed their defaults to -o2, which results in a performance drop. |
|
Interesting. Manylinux still uses |
Recent Anaconda and other Python distributions have changed to -O2 which results in a performance degradation. Manylinux and older Anacondas use -O3, so specify this to maintain behaviour.
Raysect 0.8 has been released, so since the development branch should build against Raysect's master, the
raysect-0.8-compatbranch is ready to be merged into development.