Add cylindrical and periodic mappers#388
Conversation
|
As we discussed today, these are really coordinate transforms (same dimensionality) rather than mappers (increase dimensionality). The difference is subtle but we should think about how to organise these: I think they should live in a separate submodule under |
|
I agree, let's move these to |
…s and move them to cherab.core.math.transform module.
|
The functions are renamed to |
|
Looks good. Can you add unit tests for the (By the way, test coverage can be checked by installing recent versions of Cython and Coverage and running |
|
Thanks for the review, @jacklovell. I've added tests for the |
|
Thanks. Looks good to me now. |
This solves #387 by extending the collection of Cherab mappers with
PeriodicMapper#D,VectorPeriodicMapper#D,CylindricalMapperandVectorCylindricalMapper.The periodic mappers are needed to handle the results of simulations carried out with periodic boundary conditions, while the cylindrical mappers are needed to handle the functions defined in cylindrical coordinates.
For example, with the new mappers a 3D function defined in cylindrical coordinates on a 20° toroidal sector can be mapped with:
and a vector function can be mapped with: