Skip to content

Add Integrator2D base class#473

Merged
jacklovell merged 3 commits intocherab:developmentfrom
Mateasek:feature/integrate2d
Mar 24, 2025
Merged

Add Integrator2D base class#473
jacklovell merged 3 commits intocherab:developmentfrom
Mateasek:feature/integrate2d

Conversation

@Mateasek
Copy link
Member

This is the base class for Integrator2D proposed in #472

I mostly copy-pasted the Integrator1D by @vsnever

@vsnever
Copy link
Member

vsnever commented Jan 14, 2025

Hi @Mateasek,

Thanks for this PR. The Integrator2D base class takes y_lower and y_upper as doubles and not as Function1D objects. In general, the boundaries for y should be a function of x. Does your interface cover all the integration cases in #471?

@Mateasek
Copy link
Member Author

Mateasek commented Jan 15, 2025

Hi @vsnever,

In general, the boundaries for y should be a function of x.

This is a good point, I will change it.

Does your interface cover all the integration cases in #471?

I hope so. The model I'm working on (at least for now) needs to integrate only over 2 dimensions. I simplify the radiated spectrum, otherwise it would need 3D integrator which for now seems unnecessary and too computationally demanding. If 2D is not enough, I can always add 3D integrators and we will have 2D for future usage in the worst case.

Copy link
Member

@vsnever vsnever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's perfect now! Thanks.

@Mateasek
Copy link
Member Author

Thanks for review @vsnever

@Mateasek Mateasek linked an issue Feb 4, 2025 that may be closed by this pull request
@jacklovell jacklovell merged commit 89945ba into cherab:development Mar 24, 2025
6 of 8 checks passed
@Mateasek Mateasek mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add 2D integrator

3 participants