Add Integrator2D base class#473
Merged
jacklovell merged 3 commits intocherab:developmentfrom Mar 24, 2025
Merged
Conversation
Member
Member
Author
|
Hi @vsnever,
This is a good point, I will change it.
I hope so. The model I'm working on (at least for now) needs to integrate only over 2 dimensions. I simplify the radiated spectrum, otherwise it would need 3D integrator which for now seems unnecessary and too computationally demanding. If 2D is not enough, I can always add 3D integrators and we will have 2D for future usage in the worst case. |
vsnever
approved these changes
Jan 17, 2025
Member
vsnever
left a comment
There was a problem hiding this comment.
I think it's perfect now! Thanks.
Member
Author
|
Thanks for review @vsnever |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the base class for
Integrator2Dproposed in #472I mostly copy-pasted the
Integrator1Dby @vsnever