-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 회원 서비스 알림 및 마케팅 수신 동의 토글 API 구현 #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ht3064
wants to merge
8
commits into
develop
Choose a base branch
from
feat/209-member-service-marketing-agree
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b141c54
refactor: 회원 서비스 알림 수신 동의 필드명 변경
ht3064 d8fdeec
feat: 회원 엔티티에 마케팅 수신 동의 필드 추가
ht3064 0a034ff
refactor: 회원 서비스 알림 수신 동의 필드명 변경
ht3064 2795d08
feat: 회원 서비스 알림 및 마케팅 수신 동의 토글 API 구현
ht3064 4adc294
feat: 회원 정보 조회 응답에 서비스 알림 및 마케팅 수신 동의 여부 필드 추가
ht3064 71cb14d
feat: 서비스 알림 및 마케팅 수신 동의 토글 기능 테스트 추가
ht3064 8f2a8bd
refactor: 멤버별 권한 부여 상태 변경 API Swagger 설명 및 테스트 워딩 정리
ht3064 818eb19
feat: 서비스 알림 수신 동의한 회원만 대상으로 FCM 알림 전송되도록 필터링 로직 추가
ht3064 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
.../src/main/java/org/cherrypic/domain/member/dto/response/MarketingAgreeToggleResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package org.cherrypic.domain.member.dto.response; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import org.cherrypic.member.entity.Member; | ||
|
|
||
| public record MarketingAgreeToggleResponse( | ||
| @Schema(description = "마케팅 수신 동의 여부", example = "false") Boolean marketingAgree) { | ||
| public static MarketingAgreeToggleResponse from(Member member) { | ||
| return new MarketingAgreeToggleResponse(member.getMarketingAgree()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
...c/main/java/org/cherrypic/domain/member/dto/response/ServiceAlarmAgreeToggleResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| package org.cherrypic.domain.member.dto.response; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import org.cherrypic.member.entity.Member; | ||
|
|
||
| public record ServiceAlarmAgreeToggleResponse( | ||
| @Schema(description = "서비스 알림 수신 동의 여부", example = "false") Boolean serviceAlarmAgree) { | ||
| public static ServiceAlarmAgreeToggleResponse from(Member member) { | ||
| return new ServiceAlarmAgreeToggleResponse(member.getServiceAlarmAgree()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Term에 대한 부분 초창기에 이야기를 했던 부분인데요 Term이 하나 이상이기도 하고 분리하는게 좋아보입니다!
Term을 언제 동의 했는지 보통 기록한다고 하더라구요? 그럴려면 매핑 엔티티로 관리하고 거기서 update 시간을 기록할태니 ...
그 방향이 좋지 않나 생각합니다.