Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't map combo back to hotkey, as that loses information. #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pkaminski
Copy link
Contributor

The callback sometimes needs to know what actual combo was used, for example to decide whether to allow it in a textarea or not (in case some combos in a hotkey have modifiers and others don't).

Review on Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant