Webpack

[mister-what]

Migration to Webpack and CommonJS compatibility

What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide

Migrating build system of angular-loading-bar to Webpack. Furthermore making it usable as a CommonJS module from other Webpack projects or from node.js (via require()), while keeping compatibility to direct browser usage in <script> tags.

• Migration of tests
• Migration of bower.json
• transformed CSS to SCSS for easier development (output is still CSS)
• added npm scripts to package.json
• updated dependencies
• code review

Have you provided unit tests that either prove the bugfix or cover the enhancement?

Unit tests are still working after migration. This PR does not contain functional code changes.

Related issues

#320

[faceleg]

Looks like you put a lot of work into this and I'm behind the idea!

Question: is there a reason the built files are now minified?

[faceleg]

I'm not convinced moving to SCSS is a great idea.

If this project was moved to anything, I'd personally prefer to see it moved to PostCSS.

The CSS is so simple that I really don't see a need to migrate it to a pre/post processor. @chieffancypants thoughts?

[faceleg]

Please revert this version bump, if the PR is merged we'll bump the version as part of the release process (which will generate a git tag as well)

[mister-what]

already done. See commit 0722a8e

[faceleg]

Is grunt still used?

[faceleg]

mixed ' and " in this file

[mister-what]

I will take care for this issue.

[mister-what]

I added the minification, because the build files are the thing that is used when using bower + wiredep in script tags. Maybe it makes more sense to have the minified core proper source mapped (eg. for debugging).

Reason to use SCSS is the automated vendor prefixing for rules. There were quite a lot of of vendor specific rules in the CSS. This hab bad impact on readability and is error prone.
Maybe a compromise is good at that place. Since CSS ist always valid SCSS, we can go back to form how it was before, but strip the vendor specific stuff.
I can take care for those changes later.
The reason for my change proposals is that we are migrating to webpack for the X-Force Exchange portal at the moment. We are using the loading bar and want to continue using it. But it does not go really well hand in hand with webpack. As I would guess, that we are not the only ones, having this problem, it makes sense to propose changes that don't impact the usage with script tags but allows using it as a commonjs module, too.

[mister-what]

Code changes applied (see 7922c94)

[faceleg]

CSS

As someone who doesn't use SCSS anymore and ideally never will again, I'd rather see standard CSS or PostCSS used.

Leave it to you and @chieffancypants to decide.

Minification

I suppose you could output both a built vanilla and built minified version, people can choose.

Webpack

I use webpack too, importing like: import 'angular-loading-bar' and haven't had issues - what issues have you experienced?