Fix endless timeout loop #364
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_inc() does not change the status if status is larger or equal than 0.99. So no new $timeout promises need to be created if status >= 0.99. This will fix some issues with protractor which waits until all $timeout promises are completed. Before new $timeout promises where created again and again and protractor timeouts occurred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide
_inc() does not change the status if status is larger or equal than 0.99. So no new $timeout promises need to be created if status >= 0.99.
This will fix some issues with protractor which waits until all $timeout promises are completed. Before new $timeout promises where created again and again and protractor timeouts occurred.
Have you provided unit tests that either prove the bugfix or cover the enhancement?
Test provided that no new $timeout is created after status reaches 0.99
Related issues
#337