reorder the broadcast complete event after the bar & spinner animation finishes #369
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide
I used the loading bar and a spinner template with grey overlay. I notice that my HTTP success/error callback ran first before the loading animation finish dismissing.
I found that your _completeAnimation only trigger when the bar finished the animation. It should wait for both bar and spinner animation finished animating and put it as complete.
Additionally
the $animate.leave, returns a promise when they are finished animating, so by putting
$animate.leave(...)
$rootScope.$broadcast(...)
would result the broadcast to run asynchronously.
it should be:
var promise = $animate.leave(...)
promise.then(function(){
$rootScope.$broadcast(...)
})
Have you provided unit tests that either prove the bugfix or cover the enhancement?
no