Merge pull request #723 from chinapandaman/PPF-722

PPF-722: make middleware sample value respect max schema boundary

PyPDFForm/middleware/dropdown.py

@@ -28,4 +28,4 @@ def schema_definition(self) -> dict:
     def sample_value(self) -> int:
         """Sample value of the dropdown."""
 
-        return 0
+        return len(self.choices) - 1

PyPDFForm/middleware/radio.py

@@ -28,4 +28,4 @@ def schema_definition(self) -> dict:
     def sample_value(self) -> int:
         """Sample value of the radiobutton."""
 
-        return 0
+        return self.number_of_options - 1

PyPDFForm/middleware/text.py

@@ -42,4 +42,4 @@ def schema_definition(self) -> dict:
     def sample_value(self) -> str:
         """Sample value of the text field."""
 
-        return self.name
+        return self.name[:self.max_length] if self.max_length is not None else self.name

tests/test_dropdown.py

@@ -6,12 +6,14 @@
 
 
 def test_schema(sample_template_with_dropdown):
-    schema = PdfWrapper(sample_template_with_dropdown).schema
+    obj = PdfWrapper(sample_template_with_dropdown)
 
-    for key, value in schema["properties"].items():
+    for key, value in obj.schema["properties"].items():
         if key == "dropdown_1":
             assert value["maximum"] == 3
 
+    assert obj.sample_data["dropdown_1"] == 3
+
 
 def test_dropdown_not_specified(sample_template_with_dropdown):
     assert (

tests/test_functional.py

@@ -406,6 +406,17 @@ def test_sample_data(sejda_template_complex):
         pass
 
 
+def test_sample_data_max_boundary(sample_template_with_comb_text_field):
+    obj = PdfWrapper(sample_template_with_comb_text_field)
+    try:
+        validate(instance=obj.sample_data, schema=obj.schema)
+    except ValidationError:
+        raise AssertionError from ValidationError
+
+    assert obj.sample_data["LastName"] == "LastNam"
+    assert obj.sample_data["Gender"] == 1
+
+
 def test_fill_right_aligned(
     sample_template_with_right_aligned_text_field, pdf_samples, request
 ):